Move first_name and last_name to only be displayed for user importer. #5292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmeltzer
force-pushed
the
importer-names
branch
from
4d5bab0
to
aa41cac
Compare
|
I think we should probably use First Name Last Name for everything. Last Name can be blank tho (since last name isn't required on the user object.) |
… Also sort items alphabetically regardless of their source.
dmeltzer
force-pushed
the
importer-names
branch
from
aa41cac
to
bdb9dbe
Compare
|
But that means we'd need to update the createUsernameFromFullName witchcraft as well, since we'd be passing it multiple names instead of one name. |
|
Yeah. It also means that people used to the current import format would need to adapt, and I suspect there are more people using the asset importer than the user importer... Maybe it's extend first_name/last_name support to the asset importer, but leave full name support for backwards compat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also swapped to sorting items alphabetically regardless of if they are general options, or specific to the category of item being imported. Hopefully this clears up some confusion during mapping.
Long term I think we should standardize on either a "full name" field (currently used in asset importer) or a "first name" and "last name" field (Currently used in user importer.) Too many names.