Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for dark-green.css to include more in template. #5122

Merged
merged 2 commits into from
Mar 2, 2018
Merged

Patch for dark-green.css to include more in template. #5122

merged 2 commits into from
Mar 2, 2018

Conversation

mesmerus
Copy link

Added several new rules, to include little bits that weren't previously. Mostly centered around the new 'form' page and the various settings pages.

I'm definitely done for today after this; I need to go back to actually adding items myself! Its now more than good enough for me, so I shouldn't be annoyed at something enough to change it again.

Also of note, there's only three hours left in "today" for me. :P

Tim F added 2 commits February 27, 2018 21:01
Added several new rules, to include little bits that weren't previously. Mostly centered around the new 'form' page and the various settings pages.
Fixed buttons for "View All" on main page. Missed those previously. Well, the buttons were included, but not the hover effects.
@mesmerus mesmerus requested a review from snipe as a code owner February 28, 2018 02:09
@mesmerus mesmerus mentioned this pull request Feb 28, 2018
@snipe snipe merged commit 4f04911 into snipe:develop Mar 2, 2018
@snipe
Copy link
Owner

snipe commented Mar 3, 2018

I've moved this file to public/css/skins, FYI. I'm also noticing that it's not using the theme header color, even if one isn't specifically set to override. (This skin looks great, btw.)

screen shot 2018-03-02 at 5 52 11 pm

Right now, in the settings, we're pulling in the custom CSS and header color business after the theme selector. Not sure how to make this work without having people specify the header color.

Part of the problem is that we assume the blue skin (since we didn't have themes before). In the <body> tag, we invoke skin-blue and in a few other places. I think we need to think through a better way to handle those styles in a themed world.

@mesmerus
Copy link
Author

mesmerus commented Mar 3, 2018

Yeah, I don't know how to call/read the picker you've got the header at the moment. If you look in the CSS, the first section is just called :root and one of the lines has a comment saying to make it the same as the header (unless you want a dual-color theme, that is).

You can tell what my header is from the way the code is by default.

I'm thinking I'ma set up another theme or two just to give you an idea of what I mean, and make a PR.

Either (a) we make a bunch of copies of my CSS, and just alter lines 2~8, and name them different things, or (b) we put five more pickers in underneath the header one you've got already in branding and point those at one CSS file.

Another idea, (c) is to have pre-made "themes" to pick from. Then if you want to pick your own, just change the values in the config (or in the pickers, if we make a nice GUI element).

Basically,

CSS Fiend Make your own CSS code
^
| Copy my code and change the hex values
|
| Pick your own colors like the header already is
v
Noob-friendly Choose from pre-generated themes

Are the options I can think of (although I'm up rather late tonight, having just done a deep-clean and mod to my desktop). The element skin-blue isn't really harmful, albeit a tad confusing for anyone who doesn't like CSS. It's just a name like any other. But by the same token, the code I've done up does assume the blue skin as a "default", as rather than editing the files on disk I used the custom box.

We could just as easily make a copy of the current theme, just without really changing the options easily enough. Just the palette that was in use before, whereas I chose custom colors as I went.

At the moment my code doesn't touch the header, because that's already selectable easily enough, so I didn't bother. If you want, I can incorporate it when I'm able, and then we can either have 6 pickers or make it disappear with the theme selectors. Either way, I do think the custom CSS box should stay, as an 'expert' option.

EDIT: Thanks, I like dark, and the light but not neon green seemed like a nice pair. I can't tell you why that's nice (I have not taken an art class since HS), but I can tell it looks nice! :P

EDIT 2: If you also like dark themes, check out StylishThemes/GitHub-Dark

EDIT 3: Oh, I see you made some already, nice! I assume skin-blue-light.css is the default blue, yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants