snipeit.sh improvements #4708
Merged
snipeit.sh improvements #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagom62
force-pushed
the
installer_cleanup
branch
2 times, most recently
from
ed671a9 to
1f87ffd
Compare
|
Sorry, I seem to have lost track of this one. Should this still be merged? |
|
I have been tied up with other things. Will get back on this in a week or so. |
tiagom62
force-pushed
the
installer_cleanup
branch
from
1f87ffd to
e91ef01
Compare
tiagom62
force-pushed
the
installer_cleanup
branch
from
778ee6c to
f531b87
Compare
|
Good to go 👍 |
|
Woot! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge yet.
Consistent-ish install across all supported operating systems.
Condensed down duplicate code.
Make shellcheck happy.
Fix a couple bugs here and there.
Does anyone know why we manually add
127.0.0.1 hostname fqdnto /etc/hosts? Why would someone use something other than the current hostname and fqdn?Removing this does not affect any of the operating systems I tested on.