-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small UI Changes #4404
Small UI Changes #4404
Conversation
Removed min-height from Assets by Status
@@ -178,7 +178,7 @@ class="table table-striped snipe-table" | |||
</div> <!--/row--> | |||
<div class="row"> | |||
<div class="col-md-6"> | |||
<div class="box box-default" style="min-height: 400px;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As min-height is set when you collapse the box it doesn't collapse only hides the content, if there is a better way i'm happy to change it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. Yeah, I can see what you mean. Unfortunately that pie chart can show up funny on some browsers if a min height isn't set. Maybe put it inside of a div that has a min-height (within the box-default div)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about attaching the min-height to the box-body instead of the entire box? save adding another div
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give it a try - if it works, I'm cool with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i pushed the change anyways :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-P
@@ -513,7 +513,7 @@ | |||
@endcan | |||
|
|||
@can('backend.interact') | |||
<li> | |||
<li class="treeview"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this actually do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes the rounded corner on the settings menu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is also used on the Assets and Reports menus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, right! Thanks!
This is 2 of the 3 issues from #4403
I'm not 100% sure on the ramification of removing the
min-height
from the Assets by status boxAs always let me know if I need to change or revert anything.