General cleanup and get ubuntu install working. #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmeltzer
reviewed
Oct 3, 2017
| if [ "$version" == "16.04" ]; then | ||
| log "apt-get install -y git unzip php php-mcrypt php-curl php-mysql php-gd php-ldap php-zip php-mbstring php-xml" & pid=$! |
There was a problem hiding this comment.
Does this need to be expanded to work on 16.10 and 17.04 ? I'm guessing the packages are named "php" on most everything now.. Can't remember the history of this.
There was a problem hiding this comment.
Absolutely. I was having trouble downloading the 17.04 iso. So i will look into this later today.
Still have a bit to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Ubuntu now installs. Tested on 16.04.
*Other misc cleanup.