Fix various installer issues. #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doctrine/inflector (and related bits) were fixed to use the latest php5 version. It's still a good idea to require php7 for future proofing at this point, but snipe-it should run with php5 as of current develop. |
|
Unless there is a good reason to stick with php5, I vote for php7 across the board for the reason you stated. |
tiagom62
force-pushed
the
centos7_install_fixes
branch
from
001f88a to
410b359
Compare
|
Yeah, while we'll continue to support php5 as long as the version of laravel we're using does, I don't see any reason not to use php7 when we're installing php for them. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this pr is better.
Fixed various installer issues. V4 was unable to install on centOS 7 and 6.
Global
*Consistent indentation of spaces instead of mixed spaces and tabs.
*Switched to copying .env.example and setting values using sed.
CentOS 7 specific
*Switched centOS 7 installs to PHP7.1. doctrine/inflector v1.2.0 requires php ^7.0
*Added php71u-json required by composer.
*Added php71u-simplexml required by aws-sdk-php.
*Created cron for laravel scheduler.
*Run key:generate before migrations.
*Run migrations during install.
*Remove passport:install. Web setup handles this.
CentOS 6 specific
*Switched centOS 6 installs to PHP7.1. doctrine/inflector v1.2.0 requires php ^7.0
*Added php71u-json required by composer.
*Added php71u-simplexml required by aws-sdk-php.
*Switched to using git clone from wget for getting the application.
*Run key:generate before migrations.
*Run migrations during install.
*Remove passport:install. Web setup handles this.
More pr's to come. Will be testing and fixing installs for other distros.
View the Concise diff because of the indentation changes here