Fixes for Red Hat Enterprise Linux 7 and CentOS 6 #3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHEL uses "rhel" in the ID field in /etc/os-release. We'll leave "redhat" in the script just in case. Also, RHEL uses a two digit version number in the VERSION_ID field. So instead of looking for just "7", look for anything that starts with "7". This should fix RHEL installations as well as not break anything with CentOS.
McG800
changed the title
"lsb_release -s -r" returns a two digit version number (at least on recent CentOS releases) while the script is looking for a single digit version. We'll change the script so that it only looks for the version starting with 6. This fixes recent releases of CentOS, while also not breaking previous versions that may have used a single digit.
McG800
changed the title
|
Thanks! |
gibsonjoshua55
pushed a commit
to gibsonjoshua55/snipe-it
that referenced
this pull request
Aug 22, 2017
* Changes for Red Hat Enterprise Linux. RHEL uses "rhel" in the ID field in /etc/os-release. We'll leave "redhat" in the script just in case. Also, RHEL uses a two digit version number in the VERSION_ID field. So instead of looking for just "7", look for anything that starts with "7". This should fix RHEL installations as well as not break anything with CentOS. * Fixes issue snipe#3079. "lsb_release -s -r" returns a two digit version number (at least on recent CentOS releases) while the script is looking for a single digit version. We'll change the script so that it only looks for the version starting with 6. This fixes recent releases of CentOS, while also not breaking previous versions that may have used a single digit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHEL uses "rhel" in the ID field in /etc/os-release. We'll leave
"redhat" in the script just in case.
Also, RHEL uses a two digit version number in the VERSION_ID field. So
instead of looking for just "7", look for anything that starts with "7".
This should fix RHEL installations as well as not break anything
with CentOS.
"lsb_release -s -r" returns a two digit version number (at least on recent CentOS releases) while the script is looking for a single digit version. We'll change the script so that it only looks for the version starting with 6. This fixes recent releases of CentOS, while also not breaking previous versions that may have used a single digit.