Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssetTransformer refactoring, restored tests #3407

Merged
merged 7 commits into from
Mar 14, 2017
Merged

AssetTransformer refactoring, restored tests #3407

merged 7 commits into from
Mar 14, 2017

Commits on Mar 13, 2017

  1. Refactored AssetsTransformer 

    Casted all ids to int, escaped all text values,
    @vjandrea
    vjandrea committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    90aacb5 View commit details
    Browse the repository at this point in the history

  2. Added warranty_expires attribute to Asset model 

    $asset->warranty_expires contains a Carbon object with the warranty
expiration date. Returns null when either purchase_date or
warranty_months are not set.
    @vjandrea
    vjandrea committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    59ec213 View commit details
    Browse the repository at this point in the history

  3. Ignoring php-cs cache files

    @vjandrea
    vjandrea committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    f989eb3 View commit details
    Browse the repository at this point in the history

  4. Restored asset tests expectations 

    Work in progress - tests still fail
    @vjandrea
    vjandrea committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    ec82f11 View commit details
    Browse the repository at this point in the history

  5. API controller refactoring, fixed HTTP status codes in responses

    @vjandrea
    vjandrea committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    8f5723a View commit details
    Browse the repository at this point in the history

  6. Restored $request->get - debugging

    @vjandrea
    vjandrea committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    54ad476 View commit details
    Browse the repository at this point in the history

  7. Added further checks in ApiAssetsCest::updateAssetWithPatch

    @vjandrea
    vjandrea committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    dcf6ee1 View commit details
    Browse the repository at this point in the history