Discussion: Moving to policies for controller based authorization #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the delete field.
…ates. Will allow for much more detailed permissions bits in the future.
…es/assets to policies instead of in authserviceprovider
dmeltzer
force-pushed
the
work-on-policies
branch
2 times, most recently
from
8fce9d6
to
b62ec35
Compare
Add an artisan command for installing a settings setup on travis-ci
…e id for tests that need an existing one.
dmeltzer
force-pushed
the
work-on-policies
branch
from
b62ec35
to
9fed422
Compare
…igration errors found along the way.:
|
All permissions have been moved to policies that make sense to move to policies. Unit tests have been written to check that we are gating properly. This PR also fixes/enables functional tests on travis-ci. Also, I've gone ahead and ported a lot of hardcoded /admin/blah urls to use the relevant routes, and fixed issues I encountered along the way. This should be mergable I think, and close to usable. |
…_ET. Increase lenght in mysql and add a validation
dmeltzer
changed the title
snipe
reviewed
Dec 19, 2016
| @@ -5,20 +5,20 @@ | |||
| $I->am('logged in user'); | |||
| $I->wantTo('ensure that the accessories listing page loads without errors'); | |||
| $I->lookForwardTo('seeing it load without errors'); | |||
| $I->amOnPage('/admin/accessories'); | |||
| $I->amOnPage('/accessories'); | |||
There was a problem hiding this comment.
Should probably eventually switch these to routes, since that's what we're using mostly now in the app
There was a problem hiding this comment.
Yeah. I'm not 100% sure what we want to do with acceptance tests long term. I think functional + api tests will replace most of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This still has a long ways to go, just wanted to get the first bit into the wild so we could discuss whether we think this is a good idea. I think it will make everything cleaner as we add in controller gates, and it will allow for much more granularity of permissions in the future as as policy methods automatically have the Item and the user as parameters.
This PR looks huge until the delete PR is merged and this is rebased, but it's just the last commit that has the changes of importance here.