Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Selection combo-box allows "Clear selected" to be an "asset" #5773

Closed
tjone270 opened this issue Jul 3, 2018 · 0 comments
Closed

Bug: Selection combo-box allows "Clear selected" to be an "asset" #5773

tjone270 opened this issue Jul 3, 2018 · 0 comments
Labels
✋ bug Confirmed bug 👩‍💻 ready for dev These issues are ready for someone to work on them - take your pick!

Comments

@tjone270
Copy link

tjone270 commented Jul 3, 2018

daeb4cc9-a7a2-4ccc-adad-aede57a02ba4

As you can see in this GIF, you can pick "Clear selected" as an asset.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@snipe snipe added ✋ bug Confirmed bug 👩‍💻 ready for dev These issues are ready for someone to work on them - take your pick! labels Jul 6, 2018
snipe pushed a commit that referenced this issue Jul 16, 2018
* adds select2 placeholders to select lists

To allow us to clear the selection on „select2“ selects, we need a placeholder attribute

See: https://select2.org/placeholders

* Removes empty option from multiple select

select2 requires an empty option value on singular selects, but not on multiple selects.

When selecting multiple options, this empty option would be shown as selectable otherwise, not clearing the selection.

* Adds the option to clear select2 instances

Sets the correct options to allow clearing of out select2 instances. The empty placeholder is required, since clearing only works when a placeholder ist set (event an empty one).

See: https://select2.org/placeholders

* Removes the „Clear selection“ option from select lists

Since we can clear the select2 lists with their native clearing method, we can remove this hack

* Updates generated assets (css/js)
@snipe snipe closed this as completed Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋ bug Confirmed bug 👩‍💻 ready for dev These issues are ready for someone to work on them - take your pick!
Projects
None yet
Development

No branches or pull requests

2 participants