Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Custom Field: "field_encrypted" used for "show_in_email" label #5510

Closed
2 tasks done
longlivepacman opened this issue May 9, 2018 · 2 comments
Closed
2 tasks done
Labels

Comments

@longlivepacman
Copy link

longlivepacman commented May 9, 2018

Please confirm you have done the following before posting your bug report:

Describe the bug
When creating a Custom Field, the "Include the value of this field in checkout emails sent to the user? Encrypted fields cannot be included in emails." label has the "for" attribute of "field_encrypted" instead of the correct "show_in_email". Currently, clicking the label for "show_in_email" checkbox will checkmark the "field_encrypted" checkbox.
Line 108 in "snipe-it/resources/views/custom_fields/fields/edit.blade.php" needs to be changed to correct this.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '/fields/create'
  2. Click on 'Include the value of this field in checkout emails sent to the user? Encrypted fields cannot be included in emails.' label
  3. See error

Expected behavior
Clicking the "show_in_email" label will checkmark the "show_in_email" checkbox.

Screenshots
N/A

Server (please complete the following information):

  • Snipe-IT Version: v4.3.0 - build 3559 (master)
  • OS: Windows 10
  • Web Server: XAMPP (Apache)
  • PHP Version: 5.6.8

Desktop (please complete the following information):

  • OS: Window 10
  • Browser Firefox, Chrome
  • Version: 59.0.3, 66.0.3359.139

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@snipe
Copy link
Owner

snipe commented May 9, 2018

Since you seem to have already figured out the solution, can you open a PR for this?

tilldeeke added a commit to tilldeeke/snipe-it that referenced this issue Jul 8, 2018
tilldeeke added a commit to tilldeeke/snipe-it that referenced this issue Jul 8, 2018
@stale
Copy link

stale bot commented Jul 8, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Jul 8, 2018
tilldeeke added a commit to tilldeeke/snipe-it that referenced this issue Jul 12, 2018
tilldeeke added a commit to tilldeeke/snipe-it that referenced this issue Jul 12, 2018
@stale stale bot closed this as completed Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants