Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cosmetic bugs #4205

Closed
2 tasks
tbradsha opened this issue Oct 12, 2017 · 2 comments
Closed
2 tasks

Various cosmetic bugs #4205

tbradsha opened this issue Oct 12, 2017 · 2 comments

Comments

@tbradsha
Copy link

tbradsha commented Oct 12, 2017

Expected Behavior (or desired behavior if a feature request)

Typo-free code and display ;^)


Actual Behavior

Nearly typo-free code and display.


Please confirm you have done the following before posting your bug report:


Provide answers to these questions:

  • Version v4.0.9 build 215 (g36cbffa)

There are a few cosmetic changes that could be tweaked:

  1. In the sidebar the "All Ready to Deploy" section of Assets has extra whitespace in front of it, so it doesn't line up with the other items. (see /resources/views/layouts/default.blade.php:388). As a side note, there are double-spaces between many of the "All" and status items, but this doesn't affect it visually.
  2. When checking in an item, it says "Checkout" instead of "Check in".
  3. Nit-picky, but "checkin" should be "check-in" when a noun, and "check in" when a verb. Likewise, "checkout" should be "check out" when a verb.
  4. When hovering over the "total licenses" section in the Dashboard, there is a slight overlap (a few pixels) of the disk icon and the "more info" bar due to the disk icon being larger than the others. Perhaps bump the icon positions up 4 pixels or so?
  5. On the Import History page, it mentions "Admin < Settings", but I believe it should be a ">" (&gt;) instead. (see resources/views/hardware/history.blade.php:64)
@madd15 madd15 mentioned this issue Oct 13, 2017
snipe pushed a commit that referenced this issue Oct 14, 2017
* Fixing various UI items

* Revert css change

* Dashboard icon CSS up 4px
@snipe snipe closed this as completed Oct 14, 2017
@tbradsha
Copy link
Author

tbradsha commented Oct 17, 2017

As for checkin vs. check-in/check in and checkout vs. check out (in verb instances), is that not likely to be changed?

@tbradsha
Copy link
Author

It appears that #4 was changed back to its buggy behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants