Add request! function #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvic
reviewed
Mar 30, 2023
|
Hi and thanks for the PR! I'm willing to add this, please just update the tests as pointed out by @dvic and move the new function definition to get rid of this warning: |
|
I didn't know about Credo, but I've fixed the error and now Credo and tests are all passing locally. |
Ubuntu 18.04 is no longer supported
|
It looks like CI was failing because Github deprecated and removed the Ubuntu 18.04 Actions runner image: actions/runner-images#7388. I've updated the runner finch uses to 20.04, which should unblock CI. |
Faphouse
approved these changes
Apr 6, 2023
Faphouse
approved these changes
Apr 6, 2023
|
Hello, it looks like CI is passing. Do you have any more feedback or anything else I should do to prepare this PR for merging? |
sneako
approved these changes
Apr 11, 2023
|
Hey @sneako, thanks for merging this in! Would you mind cutting a new release too? |
|
just published v0.16.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases where I want to raise an exception on request failure. Instead of writing the
withblock every time or writing a helper function in my own code, it would be convenient to have a bang variation ofrequest.Let me know what you think. If this is accepted, it would be great if you could also cut a release after merging so I could start using the new function. Thanks!