README.md example workflow patch

.eslintrc.json

@@ -13,6 +13,7 @@
     "project": "./tsconfig.json"
   },
   "rules": {
+    "i18n-text/no-en": "off",
     "no-console": "off",
     "filenames/match-regex": "off",
     "github/array-foreach": "off",
@@ -21,6 +22,7 @@
     "eslint-comments/no-use": "off",
     "import/no-namespace": "off",
     "no-unused-vars": "off",
+    "no-shadow": "off",
     "@typescript-eslint/no-unused-vars": "error",
     "@typescript-eslint/explicit-member-accessibility": [
       "error",

.github/workflows/test.yml

@@ -11,11 +11,12 @@ jobs:
         uses: Equip-Collaboration/diff-line-numbers@v1.0.0
         with:
           include: '["\\.ts$"]'
+          node-version: '16'
       - name: Print line numbers of changed lines
         run: echo Line numbers = ${{ toJSON(steps.diff.outputs.lineNumbers) }}
       - name: Detecting files changed
         id: files
-        uses: futuratrepadeira/changed-files@v3.2.1
+        uses: umani/changed-files@v4.0.1
         with:
           repo-token: ${{ github.token }}
           pattern: '^.*\.ts$'

README.md

@@ -37,7 +37,7 @@ jobs:
           include: '["\\.ts$"]'
       - name: Detecting files changed
         id: files
-        uses: futuratrepadeira/changed-files@v3.2.1
+        uses: umani/changed-files@v4.0.0
         with:
           repo-token: ${{ github.token }}
           pattern: '^.*\.ts$'
@@ -46,7 +46,7 @@ jobs:
           echo 'Files modified: ${{steps.files.outputs.files_updated}}'
           echo 'Files added: ${{steps.files.outputs.files_created}}'
           echo 'Files removed: ${{steps.files.outputs.files_deleted}}'
-      - uses: Arhia/action-check-typescript@v0.11
+      - uses: snapshift/action-check-typescript@v1.1.0
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           use-check: true
@@ -55,6 +55,8 @@ jobs:
           files-added: ${{steps.files.outputs.files_created}}
           files-deleted: ${{steps.files.outputs.files_deleted}}
           line-numbers: ${{steps.diff.outputs.lineNumbers}}
+          output-behaviour: both
+          comment-behaviour: new
 ```
 ## Customize the check  
 
@@ -74,6 +76,21 @@ Value|Behaviour
 `errors_in_pr`| Check fails if any errors are present in the files added/modified in the PR branch (even if already in base branche).  
 `errors_in_code`| Check fails if any errors are present in the whole branch.  
 
+The output behaviour depends on the value of `output-behaviour`
+
+Value|Behaviour
+-- | --
+`comment` | Default, comments on the PR with the errors found for this run.
+`annotate` | Uses github line annotations with the errors found for this run.
+`both` | Does both of the above.
+
+The comment behaviour depends on the value of `comment-behaviour`
+
+Value|Behaviour
+-- | --
+`new` | Default, adds a new comment for every run of the action.
+`edit` | Updates a previous run's comment, if one exists, otherwise creates a new comment.
+
 ## Use a specific tsconfig file
 
 By default, this actions uses tsconfig file located at './tsconfig.json'   
@@ -86,4 +103,4 @@ parameter `ts-config-path` :
 
 ```yml
   ts-config-path: './tsconfig.check.json'
-```
+```

__tests__/main.test.ts

@@ -14,9 +14,9 @@ test('1. parse tsc error line', () => {
   const errorParsed = parseTscErrorLine(line, tscMatcher)
   expect(errorParsed).toBeDefined()
   expect(errorParsed.fileName).toEqual('src/main.ts')
-  expect(errorParsed.line).toEqual('39')
-  expect(errorParsed.column).toEqual('11')
-  expect(errorParsed.code).toEqual('1155')
+  expect(errorParsed.line).toEqual(39)
+  expect(errorParsed.column).toEqual(11)
+  expect(errorParsed.code).toEqual(1155)
   expect(errorParsed.severity).toEqual('error')
   expect(errorParsed.message).toEqual("'const' declarations must be initialized.")
 })
@@ -26,9 +26,9 @@ test('1.2 parse tsc error line with pipe ', () => {
   const errorParsed = parseTscErrorLine(line, tscMatcher)
   expect(errorParsed).toBeDefined()
   expect(errorParsed.fileName).toEqual('server/webAPI/sal/webApiSalAddUpdate.ts')
-  expect(errorParsed.line).toEqual('45')
-  expect(errorParsed.column).toEqual('41')
-  expect(errorParsed.code).toEqual('2345')
+  expect(errorParsed.line).toEqual(45)
+  expect(errorParsed.column).toEqual(41)
+  expect(errorParsed.code).toEqual(2345)
   expect(errorParsed.severity).toEqual('error')
   expect(errorParsed.message).toEqual("Argument of type '(err?: Error | null | undefined, client?: PoolClient | undefined, sal_id?: number | null | undefined) => void' is not assignable to parameter of type 'IWebApiCallback'.")
 })
@@ -42,32 +42,32 @@ test('2. parse output', () => {
   expect(linesParsed).toHaveLength(2)
   expect(linesParsed[0].fileName).toEqual('src/main.ts')
   expect(linesParsed[1].fileName).toEqual('src/main.ts')
-  expect(linesParsed[1].column).toEqual('11')
+  expect(linesParsed[1].column).toEqual(11)
 })
 
 test('3. compareErrors', () => {
 
   const errorsBefore: ErrorTs[] = [{
     message: 'test',
-    line: '3',
-    column: '20',
-    code: '60312',
+    line: 3,
+    column: 20,
+    code: 60312,
     fileName: 'src/fakeErrors.ts',
     fileNameResolved: 'src/fakeErrors.ts'
   }]
 
   const errorsAfter: ErrorTs[] = [{
     message: 'test',
-    line: '3',
-    column: '20',
-    code: '60312',
+    line: 3,
+    column: 20,
+    code: 60312,
     fileName: 'src/fakeErrors.ts',
     fileNameResolved: 'src/fakeErrors.ts'
   }, {
     message: 'test2',
-    line: '10',
-    column: '20',
-    code: '60312',
+    line: 10,
+    column: 20,
+    code: 60312,
     fileName: 'src/fakeErrors.ts',
     fileNameResolved: 'src/fakeErrors.ts'
   }]
@@ -102,8 +102,8 @@ test('4. Parsing output', () => {
 test('5. compare errors test 1', () => {
 
   const resultCompareErrors = compareErrors({
-    errorsBefore: errorsBaseBranch as unknown as ErrorTs[],
-    errorsAfter: errorsCurrentBranch as unknown as ErrorTs[],
+    errorsBefore: errorsBaseBranch,
+    errorsAfter: errorsCurrentBranch,
     filesChanged: filesModified.split(' '),
     filesAdded: filesAdded.split(' '),
     filesDeleted: filesRemoved.split(' '),
@@ -121,10 +121,10 @@ test('5. compare errors test 1', () => {
   })
 
   const comment = getBodyComment({
-    errorsInProjectBefore: errorsBaseBranch,
-    errorsInProjectAfter: errorsCurrentBranch,
+    errorsInProjectBefore: errorsBaseBranch as unknown as ErrorTs[],
+    errorsInProjectAfter: errorsCurrentBranch as unknown as ErrorTs[],
     newErrorsInProject: resultCompareErrors.errorsAdded,
-    errorsInModifiedFiles,
+    errorsInModifiedFiles: errorsInModifiedFiles as unknown as ErrorTs[],
     newErrorsInModifiedFiles
   })
 

__tests__/test_compare_2.test.ts

@@ -8,8 +8,8 @@ import { filesAdded, filesModified, filesRemoved } from './test_compare_2/filesC
 test.skip('1. compare errors test 2', () => {
 
     const resultCompareErrors = compareErrors({
-        errorsBefore: errorsBaseBranch as unknown as ErrorTs[],
-        errorsAfter: errorsCurrentBranch as unknown as ErrorTs[],
+        errorsBefore: errorsBaseBranch,
+        errorsAfter: errorsCurrentBranch,
         filesChanged: filesModified.split(' '),
         filesAdded: filesAdded.split(' '),
         filesDeleted: filesRemoved.split(' '),

__tests__/test_compare_2/filesChanged.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.filesRemoved = exports.filesAdded = exports.filesModified = void 0;
-exports.filesModified = 'server/constants.ts server/reports/canUserGenerateReport.ts server/reports/data/getDataShared.ts server/reports/data/shared/generateCritDesc.ts server/reports/data/shared/getTitres.ts server/reports/data/shared/groupOnColNo.ts server/reports/data/shared/shared.d.ts server/reports/dataReportsMgr.ts server/reports/handlebars/handlebarsHelpers.spec.ts server/reports/handlebars/handlebarsHelpers.ts server/reports/objectToTemplateArray.ts server/reports/reportsConfigs.ts server/reports/templateMgr.ts';
-exports.filesAdded = 'server/reports/data/getDataVarsSaisRubs.ts server/reports/data/templateConfigs/configVarsSaisRubs.ts';
+exports.filesModified = 'server/api/contrats/services/GetInfosCnt.ts server/payrollEngine/PayrollEngine.ts server/payrollEngine/declaCalc.d.ts server/payrollEngine/selectBulsToRecalculate.ts';
+exports.filesAdded = '';
 exports.filesRemoved = '';