Skip to content

part of #170 : Support editing existing comment if one exists #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

part of #170 : Support editing existing comment if one exists #471

merged 1 commit into from
Apr 26, 2023

Conversation

josephluck
Copy link
Contributor

@josephluck josephluck commented Mar 24, 2023 •
edited
Loading

This PR adds a new option for whether to update the existing comment from a previous run of the action, or whether to create a new comment. Defaults to creating a new comment for backwards compatibility.

@abenhamdine fyi! 😄

@abenhamdine abenhamdine changed the title (ISSUELESS) Support editing existing comment if one exists Fix #170 Support editing existing comment if one exists Mar 27, 2023
@abenhamdine
Copy link
Contributor

abenhamdine commented Mar 27, 2023 •
edited
Loading

great addition !
Actually, I wanted to ad it myself but never found the time, see #170
thx, I will review it asap ❤️

@abenhamdine abenhamdine changed the title Fix #170 Support editing existing comment if one exists part of #170 : Support editing existing comment if one exists Mar 27, 2023
@josephluck
Copy link
Contributor Author

@abenhamdine thanks! (and thank you for the awesome action, it's helped our team massively with our Herculean effort to finish our flow -> typescript migration).

I wasn't sure how the release process works for this action, so if there's anything I've missed, please let me know 👍

@abenhamdine abenhamdine force-pushed the update-existing-comment-instead branch from df1c6c6 to e3f8a33 Compare April 26, 2023 13:14
@abenhamdine
Copy link
Contributor

@abenhamdine thanks! (and thank you for the awesome action, it's helped our team massively with our Herculean effort to finish our flow -> typescript migration).

I wasn't sure how the release process works for this action, so if there's anything I've missed, please let me know 👍

Thank you, I'm glad if this action can be useful.
I wil run some tests, and release a new version soon.

@abenhamdine abenhamdine force-pushed the update-existing-comment-instead branch from e3f8a33 to 093f51f Compare April 26, 2023 13:24
abenhamdine
abenhamdine approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@abenhamdine abenhamdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thx again ! ❤️

@abenhamdine abenhamdine merged commit 6fcaac2 into snapshift:main Apr 26, 2023
@abenhamdine abenhamdine mentioned this pull request Apr 26, 2023
Closed
@C0dex73 C0dex73 mentioned this pull request Feb 21, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abenhamdine abenhamdine abenhamdine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephluck @abenhamdine