fixes #21 invalid key lengh error node 6 #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarkuo
changed the title
Member
|
Hi @oscarkuo , thanks a lot for your pull request. I'll check out next weekend how much work it would be to switch everything over to Buffer without loosing compatibility to older Node.js versions. I will then either merge your pull request or update the whole codebase. |
Member
|
I decided to merge your pull request for now, while also starting to work on an updated branch, which will probably break backwards compatibility to older Node.js versions but should offer some improvements as well, one of them being to use Buffer everywhere. Thanks once more! |
ppmathis
pushed a commit
that referenced
this pull request
Sep 11, 2016
ppmathis
pushed a commit
that referenced
this pull request
Sep 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see http://stackoverflow.com/questions/37278228/invalid-key-length-after-upgrading-to-nodejs-6
and nodejs/node#6813
The optimal solution is probably to change your code to use Buffer instead of string everywhere but this works for me and hopefully illustrates what needs to be done.