Repository navigation
feat(setup): clarify ROMarr setup paths - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make ROMarr’s existing setup surfaces clearer about when an indexer is needed to search, when a download client is needed to grab, and how the client-reported completed path maps to the library root inside the container. Keep browsing/local-library work usable when acquisition services are absent. Add optional follow-ups for DAT checks, import lists, plugins, and playback integrations in the existing Get Started page and install guide. The per-repo contract records ROMarr’s specific first-use path.
Also sync the existing runner-policy guard test with the repository’s current exact runner assignments: the public-fork JIT runner JSON and the dispatch-only, main-only gVisor smoke job.
Merge
Target
main; merge after repository-required checks pass. The maintainer explicitly directed the commit, push, and merge.Validation
python3 -m pytest tests/test_workflow_runner_policy.py -q: 6 passed.git diff --checkpassed.Release note
release-notes/for this user-facing change.