-
Notifications
You must be signed in to change notification settings - Fork 0
Initial version #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a basic iOS/macOS (/tvOS/visionOS?) SDK for integrating SnapAuth.
So far:
It's been tested on-device for macOS and iOS, and in simulators for visionOS (seems ok-ish given the limitations) and tvOS (basically non-functional, but I think this is a simulator problem)
Logging is a hot mess, error handling needs (a lot of) work, and a lot of the internal names are pretty goofy. I'll file issues for all of that.
BUT the core integration experience is pretty decent:
I'd prefer a more direct async/await approach, but this is probably the more native experience and trying to work through threading the
ASAuthorization
callbacks back into async/await is probably not a good time.Specifically with loading it like this in SwiftUI and a single view, it's a bit error-prone, since you can easily forget to bind the delegate - and then everything silently fails.
There are also some Apple bugs where the internal ASAuthorization delegate methods aren't called in some failure scenarios, and the whole domain linking process is a pain. They're a bit tricky to repro but I'll file radars for all of them once I get it figured out.