Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate cypress and fix virtual scroll breaks on last chunk #2853

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Migrate cypress and fix virtual scroll breaks on last chunk #2853

merged 6 commits into from
Nov 21, 2023

Conversation

nick-lai
Copy link

@nick-lai nick-lai commented Nov 15, 2023 •
edited
Loading

@nick-lai nick-lai marked this pull request as ready for review November 15, 2023 08:39
@caseyjhol caseyjhol self-requested a review November 15, 2023 21:25
@caseyjhol
Copy link
Member

caseyjhol commented Nov 17, 2023 •
edited
Loading

Thanks for this!

caseyjhol
caseyjhol requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@caseyjhol caseyjhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to update .github/workflows/cypress.yml to use cypress-io/github-action@v6 as well (Cypress v10 support was added in cypress-io/github-action@v4).

@nick-lai
Copy link
Author

nick-lai commented Nov 21, 2023 •
edited
Loading

I think you'll need to update .github/workflows/cypress.yml to use cypress-io/github-action@v6 as well (Cypress v10 support was added in cypress-io/github-action@v4).

The cypress-io/github-action was updated to v6 in commit 290306d.

@caseyjhol caseyjhol merged commit bd05260 into snapappointments:dev Nov 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyjhol caseyjhol Awaiting requested review from caseyjhol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nick-lai @caseyjhol