Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(close): Header example with button close #2608

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ajaypatelaj
Copy link

BS5 changed the close button class to btn-close: https://getbootstrap.com/docs/5.0/components/close-button/
Added class with float utility

BS5 changed the close button class to btn-close: https://getbootstrap.com/docs/5.0/components/close-button/
Added class with float utility
@caseyjhol caseyjhol changed the base branch from main to dev April 20, 2022 21:09
Copy link
Member

@caseyjhol caseyjhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the close button in Bootstrap 3 and Bootstrap 4. A solution may be to:

  • remove × from inside the button
  • via CSS, set .close content to the unicode for ×
  • set classNames.CLOSEBUTTON = 'close' by default. If version is >= 5, set classNames.CLOSEBUTTON = 'btn-close float-end'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants