Seed node2vec random walks from clock instead of current time. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to time(NULL) return the current calendar time in seconds since 1 January 1970. Node2vec runs which are started in the same second (e.g. when automated) therefore have the same seed and consequently the same embedding. To enable comparing different embeddings which were created automatedely this commit introduces seeding based on TSysTm::GetPerfTimerTicks(), as e.g. already used in randwalk.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure how the contributing guidelines for this repository work, so please forgive me if this is not the exact right way.
This PR would already be superseded by #191 from @maxaalexeeva which would allow passing in a seed as a parameter to node2vec. In the long run, I think @maxaalexeeva s PR would benefit both people needing node2vec to be deterministic and those wanting it to be consistently non-deterministic. This PR introduces a minor change that makes node2vec consistently non-deterministic by using a different seeding number generation, which is already used in other places throughout the project.
Calls to time(NULL) return the current calendar time in seconds since 1 January 1970. Node2vec runs that are started in the same second (e.g. when automated) have the same seed and therefore the same embedding. To enable comparing different embeddings when running automated scripts this commit introduces seeding based on TSysTm::GetPerfTimerTicks(), as e.g. already used in
randwalk.cpp.