Skip to content

Commit 58ff504

Browse files
fix: various adaptations to changes in Snakemake 8.0
1 parent b55b770 commit 58ff504

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

snakemake_interface_executor_plugins/executors/real.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,6 @@ def additional_general_args(self):
8787
"""
8888
return []
8989

90-
def get_workdir_arg(self):
91-
return self.workflow_property_to_arg("overwrite_workdir", flag="--directory")
92-
9390
def get_job_args(self, job: ExecutorJobInterface, **kwargs):
9491
return join_cli_args(
9592
[
@@ -163,7 +160,6 @@ def format_job_exec(self, job: ExecutorJobInterface):
163160
"-m snakemake",
164161
format_cli_arg("--snakefile", self.get_snakefile()),
165162
self.get_job_args(job),
166-
self.get_workdir_arg(),
167163
general_args,
168164
self.additional_general_args(),
169165
format_cli_arg("--mode", self.get_exec_mode()),

snakemake_interface_executor_plugins/executors/remote.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -101,17 +101,6 @@ def cores(self):
101101
def get_exec_mode(self) -> ExecMode:
102102
return ExecMode.REMOTE
103103

104-
def get_default_remote_provider_args(self):
105-
if not self.disable_default_remote_provider_args:
106-
return super().get_default_remote_provider_args()
107-
else:
108-
return ""
109-
110-
def get_workdir_arg(self):
111-
if self.workflow.storage_settings.assume_shared_fs:
112-
return super().get_workdir_arg()
113-
return ""
114-
115104
def get_python_executable(self):
116105
return (
117106
sys.executable

snakemake_interface_executor_plugins/settings.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@
66

77

88
class RemoteExecutionSettingsExecutorInterface(ABC):
9+
@property
10+
@abstractmethod
11+
def jobname(self) -> str:
12+
...
13+
914
@property
1015
@abstractmethod
1116
def jobscript(self) -> str:

0 commit comments

Comments
 (0)