Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove model filtering of logcount matrix #144

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

fxwiegand
Copy link
Contributor

@fxwiegand fxwiegand commented Apr 3, 2025

This PR removes the filtering of the logcount matrices. This way they contain the same gene set across different defined models.

Summary by CodeRabbit

  • New Features
    • Updated dataset configuration so that transcript links are now optional.
    • Modified data export to include all log count entries without filtering based on transcript presence.
  • Bug Fixes
    • Disabled the filtering of columns containing only NA values in the samples data frame.

Copy link
Contributor

coderabbitai bot commented Apr 3, 2025

Walkthrough

This pull request introduces updates across three files. In the configuration file, the link to transcripts entry under the logcount_matrix dataset now includes an optional: true property. The Python postprocessing script has been modified to remove a filtering step that previously excluded rows based on transcript values, resulting in the full logcount matrix being saved. In the R initialization script, minor formatting adjustments have been made, including changed indentation and commenting out code that removed columns containing only NA values.

Changes

File(s) Change Summary
workflow/.../diffexp-template.yaml Added the optional: true property to the link to transcripts entry in the logcount_matrix dataset links.
workflow/.../postprocess_logcount.py Removed the filtering step that selected rows based on transcript values; now the original logcount_matrix is written directly to the output TSV file.
workflow/.../sleuth-init.R Adjusted formatting with changes to the indentation of the drop_na function and commented out code that removed columns with only NA values.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as User/Pipeline
    participant Script as Postprocess Logcount Script
    participant FS as File System
    Caller->>Script: Trigger postprocess
    Script->>FS: Read logcount_matrix TSV
    Script-->>Script: Load logcount_matrix DataFrame
    Note over Script: Filtering step removed
    Script->>FS: Write full logcount_matrix to output TSV
    FS-->>Script: Confirm write operation
    Script->>Caller: Signal completion
Loading

Possibly related PRs

  • feat: Add TPM matrix generation and integration into workflow #146: The changes in the main PR, which add an optional: true property to the link to transcripts entry in the diffexp-template.yaml, are related to the modifications in the retrieved PR that also involve the diffexp-template.yaml file, specifically adding a similar optional: true flag for the link to transcripts under the new tpm_matrix dataset.

Suggested reviewers

  • johanneskoester

Poem

I hop with glee in lines of code so bright,
Optional paths now guide the links just right.
Filtering steps have taken a gentle leap away,
And tidy spacing makes the R code sway.
With every change, my whiskers twitch and play—
A rabbit’s cheer for a brighter coding day! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60b6958 and 7886e0f.

📒 Files selected for processing (1)
  • workflow/resources/datavzrd/diffexp-template.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • workflow/resources/datavzrd/diffexp-template.yaml
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: run-rna-workflow
  • GitHub Check: run-three-prime-rna-workflow

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant