-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove model filtering of logcount matrix #144
base: main
Are you sure you want to change the base?
Conversation
…is the same size for all models
WalkthroughThis pull request introduces updates across three files. In the configuration file, the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as User/Pipeline
participant Script as Postprocess Logcount Script
participant FS as File System
Caller->>Script: Trigger postprocess
Script->>FS: Read logcount_matrix TSV
Script-->>Script: Load logcount_matrix DataFrame
Note over Script: Filtering step removed
Script->>FS: Write full logcount_matrix to output TSV
FS-->>Script: Confirm write operation
Script->>Caller: Signal completion
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This PR removes the filtering of the logcount matrices. This way they contain the same gene set across different defined models.
Summary by CodeRabbit