Skip to content

Harden checkout OTP: prevent dev-tools bypass, timing-safe comparison, phone pinning #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Harden checkout OTP: prevent dev-tools bypass, timing-safe comparison, phone pinning #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87cd84a
Initial plan
Copilot Feb 26, 2026
2e1e34a
Refactor checkout OTP to universal architecture: wp_footer panel, AJA…
Copilot Feb 26, 2026
d438e46
Address code review: extract session TTL constant, add phone length c…
Copilot Feb 26, 2026
aca76b3
Harden server-side OTP verification: phone pinning, timing-safe compa…
Copilot Feb 26, 2026
9ba7ca2
Address code review: extract verified_phone_matches helper, add SameS…
Copilot Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions includes/class-alpha_sms.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,12 +286,22 @@ private function define_public_hooks()
$this->loader->add_action('wp_ajax_wc_send_otp', $plugin_public, 'send_otp_for_reg');
$this->loader->add_action('wp_ajax_nopriv_wc_send_otp', $plugin_public, 'send_otp_for_reg');

// otp for guest checkout form
// Render checkout OTP panel via wp_footer (works with any theme, block checkout, Elementor, etc.)
$this->loader->add_action('wp_footer', $plugin_public, 'render_checkout_otp_modal');

// Legacy: keep classic hook for themes that embed the form inline
$this->loader->add_action('woocommerce_review_order_before_submit', $plugin_public, 'otp_form_at_checkout');
// otp validation on guest checkout

// otp validation on classic checkout
$this->loader->add_action('woocommerce_checkout_process', $plugin_public, 'validate_guest_checkout_otp');

// otp validation on block-based (Store API) checkout
$this->loader->add_action('woocommerce_store_api_checkout_update_order_from_request', $plugin_public, 'validate_block_checkout_otp', 10, 2);

// AJAX endpoint to verify OTP and set session-level verified flag
$this->loader->add_action('wp_ajax_alpha_sms_verify_checkout_otp', $plugin_public, 'ajax_verify_checkout_otp');
$this->loader->add_action('wp_ajax_nopriv_alpha_sms_verify_checkout_otp', $plugin_public, 'ajax_verify_checkout_otp');


}

Expand Down
Loading