Disable the screensaver only when playing video.

[zorbathut]

It is entirely possible that this functionality isn't desired; it looks like it was implemented at some point, then disabled in 9713cfd. I do not know if this will break things in Windows again - from looking at it code, it shouldn't, but maybe there's a bug? This is also arguably a breaking change because there is no longer a "disable screensaver even when not playing video" option.

I'd really like an option to accomplish this, however, and I'm happy to keep working on it as requested. If you'd like further testing, let me know! And if you'd prefer a different design, possibly a "Don't Disable Screensaver/Disable Screensaver When Playing/Disable Screensaver Always" dropdown, tell me the design that you'd like and I'll put that together :)

[sazeygit]

This would be a heaven send! Thank you for reading my mind.

edit: I tested out #641 and it seems to be working as expected.

So many thanks for all the great work you put into SMPlayer, it is an endless joy to use! 🙏🏼

[zorbathut]

Man, did I really send this in half a year ago?

@smplayer-dev ping!

[sazeygit]

I can't believe I have been sleeping on it all this time. I have been promising myself to take a look at this exact issue for the longest time!

[tbertels]

Tested on Plasma 5, it works fine.
Is there any reason not to merge this?

[tbertels]

Fixes issue #582

[Adityashaw]

Hi, when will this get merged?

[tbertels]

If what's holding back this merge request is the possibility of a Windows regression, I could check it there with a test build.

[IceBlizz6]

Would be great to see this get merged.
I was about to make an issue for this.

[attila-lendvai]

i also need this.

it's a major security issue that when i forget a paused video in the background, then my screen remains unlocked all the way until i return to my computer (which may end up being days).

[attila-lendvai]

@zorbathut thanks a lot for this PR!

could you please rebase it?

[zorbathut]

I'm afraid I no longer actually need this change. I've done a simple rebase and put it up at zorbathut@7e2dd1e but this is entirely untested and I don't feel good about pushing it into this branch.

I encourage someone to grab it and test it and get this upstreamed, though! Good luck!

[smplayer-dev]

I think this is already in master. a978721

[zorbathut]

You'll note I also disabled the aboutToStartPlaying() signal. I don't remember why, but I wouldn't have done that without a reason :)

Recommend someone test it out before assuming it now works.

Maybe it works! Maybe it doesn't.