Skip to content

Save recents and video position on pause #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Save recents and video position on pause #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f554fd1
Save recents and video position on pause
bakatrouble Jul 9, 2025
4308b66
Merge remote-tracking branch 'upstream/master'
bakatrouble Jul 16, 2025
2de84e8
Add setting for saving recents and video position on pause
bakatrouble Jul 16, 2025
a887890
Add a log message for saving recents/position on pause
bakatrouble Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/core.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1375,6 +1375,12 @@ void Core::pause_and_frame_step() {
void Core::pause() {
qDebug() << "Core::pause: current state:" << stateToString();

if (pref->remember_on_pause) {
qDebug("Saving recents and position");
pref->save();
saveMediaInfo();
}

if (proc->isRunning()) {
// Pauses and unpauses
if (state() == Paused) proc->setPause(false); else proc->setPause(true);
Expand Down
3 changes: 3 additions & 0 deletions src/preferences.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ void Preferences::reset() {
remember_media_settings = true;
remember_time_pos = true;
remember_stream_settings = false;
remember_on_pause = false;

#if SIMPLE_TRACK_SELECTION
alang = "";
Expand Down Expand Up @@ -704,6 +705,7 @@ void Preferences::save() {
set->setValue("remember_media_settings", remember_media_settings);
set->setValue("remember_time_pos", remember_time_pos);
set->setValue("remember_stream_settings", remember_stream_settings);
set->setValue("remember_on_pause", remember_on_pause);

#if SIMPLE_TRACK_SELECTION
set->setValue("alang", alang);
Expand Down Expand Up @@ -1302,6 +1304,7 @@ void Preferences::load() {
remember_media_settings = set->value("remember_media_settings", remember_media_settings).toBool();
remember_time_pos = set->value("remember_time_pos", remember_time_pos).toBool();
remember_stream_settings = set->value("remember_stream_settings", remember_stream_settings).toBool();
remember_on_pause = set->value("remember_on_pause", remember_on_pause).toBool();

#if SIMPLE_TRACK_SELECTION
alang = set->value("alang", alang).toString();
Expand Down
1 change: 1 addition & 0 deletions src/preferences.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ class Preferences {
bool remember_media_settings;
bool remember_time_pos;
bool remember_stream_settings;
bool remember_on_pause;

#if SIMPLE_TRACK_SELECTION
QString alang;
Expand Down
2 changes: 2 additions & 0 deletions src/prefgeneral.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ void PrefGeneral::setData(Preferences * pref) {
setRememberSettings( pref->remember_media_settings );
setRememberTimePos( pref->remember_time_pos );
remember_streams_check->setChecked(pref->remember_stream_settings);
remember_on_pause_check->setChecked(pref->remember_on_pause);

setFileSettingsMethod( pref->file_settings_method );

Expand Down Expand Up @@ -384,6 +385,7 @@ void PrefGeneral::getData(Preferences * pref) {
TEST_AND_SET(pref->remember_media_settings, rememberSettings());
TEST_AND_SET(pref->remember_time_pos, rememberTimePos());
TEST_AND_SET(pref->remember_stream_settings, remember_streams_check->isChecked());
TEST_AND_SET(pref->remember_on_pause, remember_on_pause_check->isChecked());

if (pref->file_settings_method != fileSettingsMethod()) {
pref->file_settings_method = fileSettingsMethod();
Expand Down
Loading