Add base rules #30
Draft
Add base rules #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @smortexa
Just wanted to say thanks for the great package! I've just implemented this on a work project and it's great to have all the default Laravel rules as a starting point.
Due to the sheer size of our project, however, we had a lot of failures, mainly due to our own internal abstractions and namespaces/legacy files that just need ignoring. To work around this, I've added several abstract 'base rules' that allow us to easily extend some defaults. I wanted to propose something like this for the base package as it would make extending and customising the provided rules much easier as well as being really easy to add new custom rules.
I'm opening this draft PR as an example and to gauge your interest, but would be happy to implement for the remainder of the rules. I don't think this would be a breaking change (but I may have naively overlooked something) and I think this would be a neat addition to the package, especially when adding to larger projects. Would be great to hear your thoughts?
Thanks again!