🤖 Merge PR DefinitelyTyped#60202 [react-dom] createPortal container c…

…an be a DocumentFragment by @eps1lon * [react-dom] createPortal container can be a DocumentFragment * Backport to v16 and v17
smor · May 12, 2022 · e332ea4 · e332ea4
1 parent 8810f91
commit e332ea4
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 3 deletions.
diff --git a/types/react-dom/index.d.ts b/types/react-dom/index.d.ts
@@ -25,7 +25,7 @@ import {
 export function findDOMNode(instance: ReactInstance | null | undefined): Element | null | Text;
 export function unmountComponentAtNode(container: Element | DocumentFragment): boolean;
 
-export function createPortal(children: ReactNode, container: Element, key?: null | string): ReactPortal;
+export function createPortal(children: ReactNode, container: Element | DocumentFragment, key?: null | string): ReactPortal;
 
 export const version: string;
 export const render: Renderer;

diff --git a/types/react-dom/test/react-dom-tests.tsx b/types/react-dom/test/react-dom-tests.tsx
@@ -61,6 +61,7 @@ describe('ReactDOM', () => {
         ReactDOM.createPortal(React.createElement('div'), document.createElement('div'));
         ReactDOM.createPortal(React.createElement('div'), document.createElement('div'), null);
         ReactDOM.createPortal(React.createElement('div'), document.createElement('div'), 'key');
+        ReactDOM.createPortal(React.createElement('div'), document.createDocumentFragment());
 
         ReactDOM.render(<ClassComponent />, rootElement);
     });

diff --git a/types/react-dom/v16/index.d.ts b/types/react-dom/v16/index.d.ts
@@ -25,7 +25,7 @@ import {
 export function findDOMNode(instance: ReactInstance | null | undefined): Element | null | Text;
 export function unmountComponentAtNode(container: Element | DocumentFragment): boolean;
 
-export function createPortal(children: ReactNode, container: Element, key?: null | string): ReactPortal;
+export function createPortal(children: ReactNode, container: Element | DocumentFragment, key?: null | string): ReactPortal;
 
 export const version: string;
 export const render: Renderer;

diff --git a/types/react-dom/v16/test/react-dom-tests.tsx b/types/react-dom/v16/test/react-dom-tests.tsx
@@ -60,6 +60,7 @@ describe('ReactDOM', () => {
         ReactDOM.createPortal(React.createElement('div'), document.createElement('div'));
         ReactDOM.createPortal(React.createElement('div'), document.createElement('div'), null);
         ReactDOM.createPortal(React.createElement('div'), document.createElement('div'), 'key');
+        ReactDOM.createPortal(React.createElement('div'), document.createDocumentFragment());
 
         ReactDOM.render(<ClassComponent />, rootElement);
     });

diff --git a/types/react-dom/v17/index.d.ts b/types/react-dom/v17/index.d.ts
@@ -21,7 +21,7 @@ import {
 export function findDOMNode(instance: ReactInstance | null | undefined): Element | null | Text;
 export function unmountComponentAtNode(container: Element | DocumentFragment): boolean;
 
-export function createPortal(children: ReactNode, container: Element, key?: null | string): ReactPortal;
+export function createPortal(children: ReactNode, container: Element | DocumentFragment, key?: null | string): ReactPortal;
 
 export const version: string;
 export const render: Renderer;

diff --git a/types/react-dom/v17/test/react-dom-tests.tsx b/types/react-dom/v17/test/react-dom-tests.tsx
@@ -60,6 +60,7 @@ describe('ReactDOM', () => {
         ReactDOM.createPortal(React.createElement('div'), document.createElement('div'));
         ReactDOM.createPortal(React.createElement('div'), document.createElement('div'), null);
         ReactDOM.createPortal(React.createElement('div'), document.createElement('div'), 'key');
+        ReactDOM.createPortal(React.createElement('div'), document.createDocumentFragment());
 
         ReactDOM.render(<ClassComponent />, rootElement);
     });