🤖 Merge PR DefinitelyTyped#58905 [imagemin-svgo] Use correct version …

…of svgo dependency by @martin-badin * [imagemin-svgo] Use correct version of svgo dependency * [gulp-imagemin] Update version and tests Co-authored-by: Martin Badin <MBadin@gohealth.com>
smor · Feb 22, 2022 · 4a5139a · 4a5139a
1 parent 83a8aa9
commit 4a5139a
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 20 deletions.
diff --git a/types/gulp-imagemin/gulp-imagemin-tests.ts b/types/gulp-imagemin/gulp-imagemin-tests.ts
@@ -5,41 +5,53 @@ const plugins = [
     gulpImagemin.gifsicle({ interlaced: true }),
     gulpImagemin.mozjpeg({ progressive: true }),
     gulpImagemin.optipng({ optimizationLevel: 5 }),
-    gulpImagemin.svgo({ floatPrecision: 2 })
+    gulpImagemin.svgo({
+        floatPrecision: 2,
+        plugins: [
+            {
+                name: 'removeViewBox',
+                active: true,
+            },
+            {
+                name: 'cleanupIDs',
+                active: false,
+            },
+        ],
+    }),
 ];
 
 gulp.task('build', () => {
-    return gulp.src('*.{gif,jpg,png,svg}')
-        .pipe(gulpImagemin())
-        .pipe(gulp.dest('dist'));
+    return gulp.src('*.{gif,jpg,png,svg}').pipe(gulpImagemin()).pipe(gulp.dest('dist'));
 });
 
 gulp.task('build', () => {
-    return gulp.src('*.{gif,jpg,png,svg}')
-        .pipe(gulpImagemin(plugins))
-        .pipe(gulp.dest('dist'));
+    return gulp.src('*.{gif,jpg,png,svg}').pipe(gulpImagemin(plugins)).pipe(gulp.dest('dist'));
 });
 
 gulp.task('build', () => {
-    return gulp.src('*.{gif,jpg,png,svg}')
+    return gulp
+        .src('*.{gif,jpg,png,svg}')
         .pipe(gulpImagemin({ silent: true }))
         .pipe(gulp.dest('dist'));
 });
 
 gulp.task('build', () => {
-    return gulp.src('*.{gif,jpg,png,svg}')
+    return gulp
+        .src('*.{gif,jpg,png,svg}')
         .pipe(gulpImagemin(plugins, { silent: true }))
         .pipe(gulp.dest('dist'));
 });
 
 gulp.task('build', () => {
-    return gulp.src('*.{gif,jpg,png,svg}')
+    return gulp
+        .src('*.{gif,jpg,png,svg}')
         .pipe(gulpImagemin({ verbose: true }))
         .pipe(gulp.dest('dist'));
 });
 
 gulp.task('build', () => {
-    return gulp.src('*.{gif,jpg,png,svg}')
+    return gulp
+        .src('*.{gif,jpg,png,svg}')
         .pipe(gulpImagemin(plugins, { verbose: true }))
         .pipe(gulp.dest('dist'));
 });
diff --git a/types/gulp-imagemin/index.d.ts b/types/gulp-imagemin/index.d.ts
@@ -1,4 +1,4 @@
-// Type definitions for gulp-imagemin 7.0
+// Type definitions for gulp-imagemin 8.0
 // Project: https://github.com/sindresorhus/gulp-imagemin#readme
 // Definitions by: Romain Faust <https://github.com/romain-faust>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped

diff --git a/types/gulp-imagemin/tsconfig.json b/types/gulp-imagemin/tsconfig.json
@@ -6,9 +6,6 @@
         ],
         "noImplicitAny": true,
         "noImplicitThis": true,
-        "paths": {
-            "svgo": ["svgo/v1"]
-        },
         "strictNullChecks": true,
         "strictFunctionTypes": true,
         "baseUrl": "../",

diff --git a/types/imagemin-svgo/imagemin-svgo-tests.ts b/types/imagemin-svgo/imagemin-svgo-tests.ts
@@ -9,7 +9,8 @@ imagemin(['*.svg'], {
             floatPrecision: 2,
             plugins: [
                 {
-                    removeViewBox: false,
+                    name: 'removeViewBox',
+                    active: true,
                 },
             ],
             multipass: false,

diff --git a/types/imagemin-svgo/index.d.ts b/types/imagemin-svgo/index.d.ts
@@ -5,7 +5,7 @@
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
 
 import { Plugin } from 'imagemin';
-import { Options as SvgoOptions } from 'svgo';
+import { OptimizeOptions as SvgoOptions } from 'svgo';
 
 /**
  * SVGO imagemin plugin

diff --git a/types/imagemin-svgo/tsconfig.json b/types/imagemin-svgo/tsconfig.json
@@ -6,9 +6,6 @@
         ],
         "noImplicitAny": true,
         "noImplicitThis": true,
-        "paths": {
-            "svgo": ["svgo/v1"]
-        },
         "strictNullChecks": true,
         "strictFunctionTypes": true,
         "baseUrl": "../",