Ensure tests of non-returning functions don't cause unreachability er…

…rors (DefinitelyTyped#38596)
smor · Sep 25, 2019 · 24cd81e · 24cd81e
1 parent 805bb29
commit 24cd81e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/types/node/v10/node-tests.ts b/types/node/v10/node-tests.ts
@@ -70,11 +70,11 @@ import { Buffer as ImportedBuffer, SlowBuffer as ImportedSlowBuffer, transcode,
 
         assert.equal(3, "3", "uses == comparator");
 
-        assert.fail('stuff broke');
+        if (!!true) assert.fail('stuff broke');
 
-        assert.fail('actual', 'expected', 'message');
+        if (!!true) assert.fail('actual', 'expected', 'message');
 
-        assert.fail(1, 2, undefined, '>');
+        if (!!true) assert.fail(1, 2, undefined, '>');
 
         assert.ifError(0);
 

diff --git a/types/vfile/vfile-tests.ts b/types/vfile/vfile-tests.ts
@@ -40,7 +40,7 @@ file.message('test', {
 
 file.message('test', { start: 'invalid point' }); // $ExpectError
 
-file.fail('test');
+if (!!true) file.fail('test');
 
 const infoMessage: vfileMessage.VFileMessage = file.info('test');