Skip to content

Conversation

@Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Jun 14, 2023

#377 added support for subnet-local broadcast addrs for ingress, but it was missing for egress.

@Dirbaio Dirbaio changed the title iface: add support for sending subnet-local broadcast addrs (like 192.168.1.255). iface: add support for sending to subnet-local broadcast addrs (like 192.168.1.255). Jun 14, 2023
@Dirbaio Dirbaio force-pushed the broadcast-egress branch from 58f9dc6 to 7d78370 Compare June 14, 2023 21:20
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #801 (7d78370) into master (8f4820f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
- Coverage   80.32%   80.30%   -0.02%     
==========================================
  Files          72       72              
  Lines       29060    29081      +21     
==========================================
+ Hits        23341    23354      +13     
- Misses       5719     5727       +8     
Impacted Files Coverage Δ
src/iface/interface/mod.rs 49.75% <100.00%> (+0.44%) ⬆️
src/iface/interface/tests.rs 100.00% <100.00%> (ø)
src/socket/udp.rs 84.45% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dirbaio Dirbaio added this pull request to the merge queue Jun 16, 2023
Merged via the queue into master with commit 047d6a8 Jun 16, 2023
@Dirbaio Dirbaio deleted the broadcast-egress branch June 16, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants