Skip to content

Conversation

mounten
Copy link

@mounten mounten commented Sep 11, 2025

Support for target_os nto, where uid_t, gid_t is a signed integer type.

Same implementation as in the std: https://doc.rust-lang.org/src/std/os/unix/process.rs.html#16

- define UserId, GroupId alias
- use i32 for  UserId, GroupId for target_os ntoo
@mounten mounten force-pushed the fix-nto-process-id-signed-type branch from 90e9f63 to ae27f8b Compare September 13, 2025 20:02
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can we add a CI check for this?

@mounten
Copy link
Author

mounten commented Sep 13, 2025

I don't think so. nto-qnx is only a tier 3 target.

@notgull
Copy link
Member

notgull commented Sep 14, 2025

Even so, can we at least check via cargo check?

@mounten
Copy link
Author

mounten commented Sep 14, 2025

Sadly no. cargo check also seems to require a custom compiled rustc core std for the *-nto-qnx-* targets 😞

@notgull
Copy link
Member

notgull commented Sep 14, 2025

You can use -Zbuild-std on nightly to build stdlib in CI.

@mounten
Copy link
Author

mounten commented Sep 14, 2025

You can use -Zbuild-std on nightly to build stdlib in CI.

Awesome. cargo +nightly check -Zbuild-std --target aarch64-unknown-nto-qnx800 works and would catch the error.
I'm gonna add this as a CI check.

- checking compatibility for *nto-qnx* targets
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit 8a81e28 into smol-rs:master Sep 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants