fix response body when using go_template_json #277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that body is not nil before serializing it to json.
This fixes an issue where a mock like this
returns literal
null
as a response body instead of an empty body.PS: to be honest, I think this entire
if
block is redundant because it makes the behavior inconsistent between dynamic-response mocks and static-response mocks: in static-response mocks we only allow strings asbody
and don't convert arbitrary objects into strings.