fix: reinit wall.drawable_count in StartKyoku replay handler#203
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a replay-only state initialization bug where StartKyoku rebuilt the wall tiles but left wall.drawable_count stale, which could incorrectly suppress Riichi (and other actions gated by remaining draws) in observe_event replays.
Changes:
- Reinitialize
wall.drawable_countinapply_mjai_event(StartKyoku)towall.tiles.len() - 14for both 4P and 3P replay handlers to match_initialize_round. - Add regression tests asserting
drawable_countresets correctly and that Riichi appears in legal actions in replay scenarios for both variants.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
riichienv-core/src/state/event_handler.rs |
Reset wall.drawable_count during 4P StartKyoku replay initialization to restore legality invariants. |
riichienv-core/src/state_3p/event_handler.rs |
Same drawable_count reset for 3P StartKyoku replay initialization. |
riichienv-core/src/tests.rs |
Add regression coverage for drawable_count reset and Riichi availability in replay paths (4P/3P). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #198.
wall.drawable_counttowall.tiles.len() - 14inside theStartKyokuarm ofapply_mjai_eventso it matches the invariant established by_initialize_round. Applies the same fix to the 3P replay handler.