Bugfix: Make additional capabitities optional #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec indicates that all capabilities except `urn:ietf:params:jmap:core` are optional. This commit ensures that when a session is coerced from JSON to a Session object, it doesn't throw an error when the response doesn't include optional capabilities.
|
Appreciate you developing this tool, I ran into this issue while using the fastmail JMAP API, which doesn't return |
|
@kevindkeogh Thanks for the bug report and PR! Interestingly, the I added on to your PR to retrieve the primary account ID on a best effort basis from any of the configured primary account IDs. An Exception is raised if none are found, which I don't think should happen under normal circumstances. I added a unit test for this as well. |
smkent
approved these changes
Aug 25, 2022
smkent
added a commit
that referenced
this pull request
Nov 4, 2022
Applied upstream commits: smkent/cookie-python@5a2e488...224c0e2 * 224c0e2 Merge pull request #64 from smkent/docker-compose-fixup |\ | * b500da7 Update image path in example docker-compose.yaml |/ * 89d2312 Merge pull request #63 from smkent/pytest-sugar-py |\ | * 0f40d43 Add py to dev dependencies |/ * 1b5710d Merge pull request #62 from smkent/docker |\ | * eb10487 Add README.md test cases for container publishing | * a5c094b Update README.md test cases for PyPI install instructions | * 36a988b Add Docker template bits | * 0f7d63d Set pyyaml to be a package dependency * | 838cccf Merge pull request #61 from smkent/readme-pre-commit-2 |\ \ | |/ |/| | * dfafc26 Add pre-commit to features list |/ * d24fca9 Merge pull request #60 from smkent/readme-pre-commit |\ | * 331f6d3 Update development info in cookie-python README.md for pre-commit |/ * 8534e71 Merge pull request #59 from smkent/black-template |\ | * 1dee4ce Configure black line-length in template |/ * adca1e4 Merge pull request #51 from smkent/poetry-1.2 |\ | * 285f34d Update RELEASE_POETRY_VERSION to 1.2 in CD workflows | * 676eb84 Merge remote-tracking branch 'origin/main' into poetry-1.2 | |\ | |/ |/| * | 4271b52 Merge pull request #57 from smkent/fixup-template-pre-commit-cache-id |\ \ | * | dcde9c5 Add actions/setup-python output ID in template action * | | 241a2be Merge pull request #58 from smkent/fixup-license-config |\ \ \ | |/ / |/| | | * | 830f93a Update the license value in pyproject.toml to MIT |/ / * | 6183211 Merge pull request #53 from smkent/pre-commit |\ \ | | * 93bdffc Duplicate `PYTHON_KEYRING_BACKEND` for cookie-python's unit tests | | * d394931 Move `PYTHON_KEYRING_BACKEND` env var to `poetry install` step | | * d497ab6 Avoid using a keyring backend with Poetry and Python in CI | | * 915dc95 Merge remote-tracking branch 'origin/pre-commit' into poetry-1.2 | | |\ | | |/ | |/| | * | ae00997 Update README.md test cases for README.md updates | * | fb8b920 Restore cookie-python specific Poe the Poet tasks | * | 6b66436 Update README.md in cookie-python and template | * | 13ec742 Merge remote-tracking branch 'origin/main' into pre-commit | |\ \ | |/ / |/| | * | | e1e9bca Merge pull request #54 from smkent/rm-tox |\ \ \ | * \ \ 6ffe18e Merge remote-tracking branch 'origin/main' into rm-tox | |\ \ \ | |/ / / |/| | | * | | | e36596c Merge pull request #55 from smkent/bandit-toml-toplevel * | | | 3676e2c Install bandit with the toml extra in cookie-python itself / / / * / / 68465fb Remove tox, which is unused / / * | 03641a9 Update poe tasks for pre-commit in template pyproject.toml * | 1e74925 Remove unused poe environment variables config * | 7a204be Skip some subprocess-related checks in bandit * | e634ffe Add pre-commit configuration * | 53bea95 Add pre-commit / * 7945b1c Pin poetry-dynamic-versioning to <=0.17.1 for Poetry 1.1.x compatibility * e872a4d Upgrade requests when installing Poetry * eba528c Update to Poetry 1.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec indicates that all capabilities except
urn:ietf:params:jmap:coreare optional. This commit ensures that when a session is coerced from JSON to a Session object, it doesn't throw an error when the response doesn't include optional capabilities.