Repository navigation
ui: replace native window.confirm with custom theme-aware modal - #373
Open
JonanOribe wants to merge 4 commits into
Open
JonanOribe wants to merge 4 commits into
JonanOribe wants to merge 4 commits into
Conversation
smittix
reviewed
Oct 4, 2026
smittix
left a comment
Owner
There was a problem hiding this comment.
Thanks @JonanOribe, this looks much better than the browser dialog, and it's good to have it follow the theme. A few things before this becomes the shared confirm for the rest of the app (you mentioned that as the next step):
- Make it reusable:
showCustomConfirm(title, message, onConfirm)reads as generic, but the button text is fixed to "Yes, Stop All". Could the confirm label be a parameter (default "Confirm")? - Use the theme variables throughout: the light and dark colour sets are almost identical (they already use the CSS variables), so one set would do. The title colours are fixed hex values (
#dc2626/#f87171), and those could bevar(--accent-red). Thesystem-uifont could be the app's own font variables so the pop-up matches the rest of the UI. - Keyboard and dismissal: Escape and clicking the dark backdrop should cancel. Focus should move into the pop-up when it opens (ideally to Cancel, since this is a destructive action) and go back to the Kill All button when it closes.
- Small one: the closing
}ofshowCustomConfirmhas lost its indentation.
None of these block this first step on its own, so it's fine to cover them in your follow-up PR when the other dialogs move across, as long as 1 lands before anything else uses it. Thanks again!
Contributor
Author
|
Already done @smittix |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this branch is to unify the styles of the application's modal windows, which currently use the browser's default styling.
The first iteration aimed to:
ensure consistent look and feel across different browsers (Chrome,
Firefox, Safari, etc.).
cannot be styled, and fail to adapt to the user's selected
theme (light/night mode).
discrepancies and provides a cohesive, professional user experience
aligned with the tactical dashboard design.
Before:
Now:
The next step in these iterations will involve identifying all the application's modals to achieve complete unification.