fix!: Represent TCP port as UInt16 #924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichanyoo
approved these changes
Apr 22, 2025
dayaffe
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
Same comment as companion PR. I think port should be Int until the exact place it needs to be converted. At which point we could use something like https://developer.apple.com/documentation/kernel/in_port_t to ensure it is a valid port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
[BREAKING] Changes the type for port number from
Int16toUInt16. TCP port may be from 0-65535 which is beyond the range ofInt16.This affects public interfaces for URI, Endpoint, HTTPRequest, and their associated builder types.
The change is breaking because port number is exposed as a property of several public types and parameters to public functions. The change is being made nonetheless because it is a significant impediment to not allow use of all possible TCP ports.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.