additional service specific protocol tests #3682
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There are several service specific http request/response tests from Smithy. These are similar to the protocol tests but apply only to a specific service. We were tasked with ensuring some of the S3 URI related tests were captured.
Description
We currently were running the API gateway related tests as part of the
aws/sdk-adhoc-test
package. There are also tests for machinelearning, glacier, and s3. I attempted to add all of these but hit issues.machinelearning
can be enabled but we have yet to actual implement the customization that would allow this test to pass.s3
pulls inaws-config
as a dev dependency for reasons and this causes conflicts between relocated and non-relocated runtime crates. Thesdk-adhoc-test
package does not implement any of the runtime relocation and Cargo.toml processing that thesdk
build does (nor do I want to pursue that).For now I've enabled the
glacier
tests and copied the S3 specific tests intos3-tests.smithy
so that they are built and tested with the actual S3 model. In the future we can either (1) fix the build issues allowing us to remove these tests in favor of the ones defined in Smithy or (2) ideally these tests get implemented in the real upstream service models and we don't have to do anything special to get them.Testing
Tested locally and CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.