Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

behavior version 2024-03-28 #3617

Merged
merged 21 commits into from
May 2, 2024
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d9d3a2f
Enable stalled stream protection for uploads behind new behavior version
jdisanti Mar 27, 2024
477d1d5
Add changelog entries
jdisanti Mar 27, 2024
e72da5e
Merge remote-tracking branch 'origin/main' into jdisanti-bmv-stall-up…
jdisanti Apr 12, 2024
df57d1e
Fix runtime crate version numbers after merge
jdisanti Apr 12, 2024
3f3ac63
Improve changelog message
jdisanti Apr 12, 2024
6d25692
Merge remote-tracking branch 'origin/main' into jdisanti-bmv-stall-up…
jdisanti Apr 23, 2024
4dac882
Fix deprecation error
jdisanti Apr 23, 2024
f7731ba
Fix another deprecation error
jdisanti Apr 24, 2024
a21b6d9
Fix aws-smithy-runtime version number after release
jdisanti Apr 24, 2024
510ce11
Enable stalled stream protection for uploads behind new behavior vers…
jdisanti Apr 24, 2024
27f6b18
create an IdentityCache by default when on latest BehaviorVersion
aajtodd Apr 11, 2024
abddedc
update rfc status
aajtodd Apr 25, 2024
83290df
fixup integration tests
aajtodd Apr 25, 2024
a3002e8
remove API to unset identity cache
aajtodd Apr 26, 2024
c8119f5
fix test cfg
aajtodd Apr 26, 2024
3b87e39
create an IdentityCache by default when on latest BehaviorVersion (#3…
aajtodd Apr 26, 2024
ef380b8
fix todo
aajtodd Apr 30, 2024
46af22d
Merge remote-tracking branch 'origin/main' into behavior-version-2024…
aajtodd May 1, 2024
91f5cd7
bump versions
aajtodd May 1, 2024
79c1b37
fix issue reference
aajtodd May 1, 2024
8c58076
Merge remote-tracking branch 'origin/main' into behavior-version-2024…
aajtodd May 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix todo
  • Loading branch information
aajtodd committed Apr 30, 2024
commit ef380b82bfe6fa1282deef40b420e234dd3c233a
Original file line number Diff line number Diff line change
Expand Up @@ -282,12 +282,10 @@ async fn test_stalled_stream_protection_for_downloads_is_enabled_by_default() {
"minimum throughput was specified at 1 B/s, but throughput of 0 B/s was observed"
);
// 5s grace period
// TODO(https://github.com/smithy-lang/smithy-rs/issues/3510): Currently comparing against 5 and 6 due to
// the behavior change in #3485. Once that feature/fix is released, this should be changed to only check for 5.
let elapsed_secs = start.elapsed().as_secs();
assert!(
elapsed_secs == 5 || elapsed_secs == 6,
"elapsed secs should be 5 or 6, but was {elapsed_secs}"
elapsed_secs == 5,
"elapsed secs should be 5, but was {elapsed_secs}"
)
}

Expand Down
Loading