Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPDX-License-Identifier in header comments #1377

Merged
merged 3 commits into from
May 9, 2022
Merged

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented May 7, 2022

Motivation and Context

@hyandell pointed out the SPDX-License-Identifier has an unnecessary trailing period in awslabs/aws-sdk-kotlin#601, and I think we must have copied the license header from that repository at some point in the early days of smithy-rs. This PR removes the trailing period and updates our linter.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti requested review from a team as code owners May 7, 2022 00:32
@github-actions
Copy link

github-actions bot commented May 7, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec 5.88% 82218.8 77650.12
Total requests 5.87% 7401831 6991721
Total errors NaN% 0 0
Total successes 5.87% 7401831 6991721
Average latency ms 27.66% 1.2 0.94
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 58.47% 34.34 21.67
Stdev latency ms 30.67% 2.13 1.63
Transfer Mb 5.87% 769.42 726.79
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

Copy link
Contributor

@crisidev crisidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice sed and replace :)

Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! this really gave chrome a run for its money 😅

@Velfi Velfi merged commit a0539e2 into main May 9, 2022
@Velfi Velfi deleted the jdisanti-fix-spdx-headers branch May 9, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants