misc: enable ignored kn tests #1292
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
ianbotsf
reviewed
Jun 5, 2025
Comment on lines
-58
to
+56
| withTimeout(10.seconds) { | ||
| withTimeout(1000.seconds) { |
There was a problem hiding this comment.
Question: 16 minutes and 40 seconds is a very long timeout. Shouldn't we be able to handle 1000 calls in 10 seconds? How long is this test actually taking?
There was a problem hiding this comment.
1000 is just for testing, I'll bring it back to 10 when this is ready for review. I'm currently just testing runs of the KN tests in CI, I forgot to say so in the description. Thanks for taking a preemptive look at it though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Currently PR is being used for CI testing. NOT ready for review yet.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.