Add logging to display signing name used for sigv4 auth. #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/src/main/java/software/amazon/smithy/java/cli/SmithyCall.java
Outdated
Show resolved
Hide resolved
| @@ -269,6 +270,7 @@ private void configureAuth(DynamicClient.Builder builder, ShapeId serviceInput, | |||
| .map(ServiceTrait::getArnNamespace) | |||
| .orElse(serviceInput.getNamespace().toLowerCase())); | |||
|
|
|||
| LOGGER.fine("Using service signing name detected in model: " + signingName); | |||
There was a problem hiding this comment.
Can we move to using the smithy-logger interface in a follow-up PR instead of using JUL directly? We want to use format strings like log("Using signing service name {}", signingName); because they prevent the creation of unnecessary garbage in the form of concatenated strings. JUL does not support that.
There was a problem hiding this comment.
by the smithy-logger interface, do you mean InternalLogger or is that something different?
rhernandez35
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added FINE level logging for SigV4 configuration.