Cleanup how dynamic schemas work #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than make WrappedDocument and SchemaGuidedDocumentBuilder support all kinds of shape types, they now just support structure and document. This cleans up the handling of document and nested members so that nested structures don't have to be re-parsed each time we need to serialize them. It's also easier to figure out how the code works. Various bugs were fixed along the way and more test coverage was added.
adwsingh
force-pushed
the
dynamic-schemas-cleanup
branch
from
ee24145 to
65bb6e7
Compare
adwsingh
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than make WrappedDocument and SchemaGuidedDocumentBuilder support all kinds of shape types, they now just support structure and document. This cleans up the handling of document and nested members so that nested structures don't have to be re-parsed each time we need to serialize them. It's also easier to figure out how the code works.
Various bugs were fixed along the way and more test coverage was added.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.