Repository navigation
Emit a 'radiuschanging' event #76
Description
Activity
Please put up a pull request if you have a good strategy for adding this feature!
Thank you for your answers. I'm not sure what a
rAF slotis.
I was thinking about something very (too?) simple: addingthis._eventEmitter.emit('radiuschanging', this);in theset radiusand
this._eventEmitter.emit('centerchanging', this);in theset center.PR: #77
I am not seeing any visible difference in performance but I am keeping a very light playground: http://lab.meltedpeng.com/mapbox-gl-circle/
Edit: Oh ok, rAF for requestAnimationFrame. Never used this abbreviation.
It fires when the center changes, so reacting to the_onRadiusHandlesMouseDownand_onRadiusHandlesMouseMovelisteners.
For a more advanced styling I'd need to keep track of a circle whose radius is being dragged.
Currently we only have 'radiuschanged' which is emitted once the drag has ended. So a 'radiuschanging' could come in handy.
To be consistent, a 'centerchanging' could also be added.
What do you think? would you accept a PR with this feature?