Skip to content

Use standard logging library, reuse session for performance #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2018
Merged

Use standard logging library, reuse session for performance #14

merged 3 commits into from
Mar 14, 2018

Conversation

smithclay
Copy link
Owner

@smithclay smithclay commented Mar 14, 2018 •
edited
Loading

  • General cleanup (use AWS-friendly JSON logging library)
  • Reuse existing session on receiving new event, result is that subsequent selenium scripts execute significantly faster. Subsequent runs of the 'visit Google' script execute ~130% faster with session reuse (note: this feature can be disabled with the CLEAN_SESSIONS flag).

@smithclay smithclay merged commit 247cbe6 into master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smithclay