Ad panics when using custom tree-sitter queries

[Yappaholic]

Describe the bug

After configuring sources for ad on NixOS (I am using compiled grammars and queries from another project) I can't open files because the editor just panics.

To Reproduce

Steps to reproduce the behavior:

1. Install grammars and queries
2. Set the source paths and [[languages]] in config.toml
3. Try to open files

Expected behavior

Editor opens files without panicking and with tree-sitter highlighting.

Versions & OS Details

• OS: Linux
• Distribution NixOS
• OS Version 24.11
• ad Version commit 5bdc021

Additional context

The error:

thread 'main' panicked at src/buffer/internal.rs:412:41:
slice index starts at 74 but ends at 4
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Full backtrace (not sure if needed):
stack backtrace:
0: 0x55a77a25d087 -
1: 0x55a77a1b0b7b -
2: 0x55a77a25f50e -
3: 0x55a77a28cde2 -
4: 0x55a77a28dce3 -
5: 0x55a77a25d4f5 -
6: 0x55a77a25d459 -
7: 0x55a77a28d294 -
8: 0x55a779f76522 -
9: 0x55a779f76356 -
10: 0x55a77a097bd1 -
11: 0x55a77a0da182 -
12: 0x55a77a0d7973 -
13: 0x55a779fd8b19 -
14: 0x55a779fa657e -
15: 0x55a779fdd14d -
16: 0x55a779fc52c3 -
17: 0x55a779fda97a -
18: 0x7f7ac12b727e - __libc_start_call_main
19: 0x7f7ac12b7339 - __libc_start_main_alias_2
20: 0x55a779f7e3f5 -
21: 0x0 -

[sminez]

What is the language of the file you are trying to open? It looks as though the results of the syntax queries are producing malformed ranges (probably because they overlap and ad isn't handling that correctly) so I'll need to be see the queries you are using I think.

[Yappaholic]

I tried opening ts and nix files, not sure if the problem can occur in other languages.

The grammars and queries are fetched and compiled from helix editor (https://github.com/helix-editor/helix in runtime/queries), so I don't know if that's the case for malformed ranges

[Yappaholic]

I compiled typesciprt grammars and queries and setup them with ad, then tried opening ts file again and got the same error:

thread 'main' panicked at src/buffer/internal.rs:412:41:
slice index starts at 124 but ends at 14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[sminez]

I believe that Helix parses tree-sitter queries differently to neovim (which is what I've based the ad implementation on): helix-editor/helix#9458

So queries from Helix wont work the way you expect. That said, ad definitely shouldn't crash in this situation so I'll take a look at how to handle the results of queries that produce unexpected highlighting ranges like this.

That error you are getting is because the rendering logic expects the list of highlighted ranges to be both non-overlapping and strictly increasing (in terms of offset through the buffer) but your queries are resulting in overlapping ranges.

[Yappaholic]

Okay, thanks for help
From my usage of modal text editors, ad looks nice and promising, IMO especially the file explorer feature, which is absent in kakoune and helix. It would be really nice if the features around using different languages be more polished, so some can use it with less worrying about compilation and managing tree-sitter, just like helix does (or even neovim with TSInstall)!

[sminez]

Thanks! The language specific support is brand new and not yet released as a stable build on crates.io so there are definitely rough edges and missing features I'm afraid. I'm planning on making improvements in the near future but it'll be a while before the experience is as polished as what is currently available in neovim and helix 😄

[jcowgar]

I am experiencing the same thing with Elixir. Steps:

• Copy ~/.local/share/nvim/lazy/nvim-treesitter/queries/elixir/highlights.scm to ~/.ad/tree-sitter/queries/elixir/highlights.scm
• Copy ~/.local/share/nvim/lazy/nvim-treesitter/parser/elixir.so to ~/.ad/tree-sitter/parsers/elixir.so

I then added the Elixir language to my config.toml.

[[languages]]
name = "elixir"
extensions = ["ex", "exs"]
lsp.command = "language_server.sh"
lsp.roots = ["mix.exs"]

The output is:

❱ ad mix.exs
thread 'main' panicked at src/buffer/internal.rs:412:41:
slice index starts at 165 but ends at 9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace