Adding Dark and Luminous Substructure to the Main Deflector#2
Adding Dark and Luminous Substructure to the Main Deflector#2lobrien6 wants to merge 8 commits intosmericks:mainfrom
Conversation
…tor and handle a catalog of lens parameters
Update local directory of paltas
…erturbers to the main deflector
drphilmarshall
left a comment
drphilmarshall
left a comment
There was a problem hiding this comment.
Just a brief note on documentation
smericks
left a comment
smericks
left a comment
There was a problem hiding this comment.
This PR has functions for adding mass and light for a single perturber. It also includes functionality for generating images from a static catalog, I think originally implemented by @padma18-vb? I've added some comments requesting changes, and don't forget @drphilmarshall 's comment about adding docstrings.
|
|
||
|
|
||
| @staticmethod | ||
| def mag_to_amplitude(mag_apparent,mag_zeropoint,kwargs_list): |
There was a problem hiding this comment.
You're duplicating functions already written in the Sersic class object. It would be better to inherit from the Sersic object, and you can use super().mag_to_amplitude() to use this function if you need it, for example.
|
|
||
| return light_model_list,light_model_kwargs,light_z_list | ||
|
|
||
| class SersicPerturber(SourceBase): |
There was a problem hiding this comment.
My understanding of this class object is that it simultaneously returns the light of two objects: the main deflector and the perturber. So we wouldn't use this for painting light on subhalos, this is for the single perturber case, correct? (Just verifying my understanding).
… to give user the choice of using a catalog to input parameter values. Fix seed values
3 participants
This pull request is being created to monitor the changes to paltas that are needed to add dark and luminous substructure to the main deflectors in double and quad lens systems. Changes include added definitions in existing files and the creation of new scripts to handle new functions.
Note: the main config_handler.py file used to initiate the config files has been replaced with config_handler_catalog.py. This new config handler is able to pull multiple lens parameters from a csv file. The old config_handler.py file is kept for archival purposes only and has since been deprecated for the purposes of generating large test sets with added substructure.