Making mpi4py 3.1.5 new minimum version for build #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timryanb
requested review from
gjkennedy,
A-CGray,
markleader,
sean-engelstad,
bburke38 and
SeiyonArulampalam
|
I'd appreciate it if each of the reviewers could try installing tacs on their machines using this PR and let me know if they run into any compatibility issues. @gjkennedy @A-CGray @sean-engelstad @bburke38 @SeiyonArulampalam |
A-CGray
approved these changes
Nov 12, 2024
|
Got it to work on my end as well using:
|
timryanb
changed the title
timryanb
changed the title
This was referenced Dec 12, 2024
Merged
|
Seems to have installed correctly on my Mac. It updated mpi4py in the process to mpi4py==3.1.6. This was using python==3.9.16 (I am using an older version of Python for compatibility with something else). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.12+ seems to be incompatible with older versions of mpi4py. In order to fix this we'll need to bump up minimum mpi4py version to 3.1.5.