Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ESP8266 support #4

Merged
merged 3 commits into from
Mar 27, 2022
Merged

add ESP8266 support #4

merged 3 commits into from
Mar 27, 2022

Conversation

kuwatay
Copy link
Contributor

@kuwatay kuwatay commented Mar 27, 2022

I added ESP8266 support.
It worked with minimum modification.
I tested on Arduino IDE with 'examples/01_BasicUsage/01_BasicUsage.ino'

add ESP8266 support
@smdn
Copy link
Owner

smdn commented Mar 27, 2022

Thanks for the PR!

Would you please confirm or report that the other examples can be compiled without error?
If all examples can be compiled without any problem, I will merge this PR and will release new version.

@kuwatay
Copy link
Contributor Author

kuwatay commented Mar 27, 2022

thank you for your comment. I changed all examples can be compiled w/o error. Note that example3 use three ADC but ESP8266 has only one. I assign A0, A0+10, A0-10 for original labels.

@smdn
Copy link
Owner

smdn commented Mar 27, 2022

Thank you for the modification of example codes. That's very helpful!

Please also push a commit which reverts the changing of VERSION.

@kuwatay
Copy link
Contributor Author

kuwatay commented Mar 27, 2022

here comes.

@smdn
Copy link
Owner

smdn commented Mar 27, 2022

Ah, that's not what I meant.
What I want to say was "keep the version string, do not change it".

Ok, anyway I will fix them after merging.

@smdn smdn merged commit 5ad6d42 into smdn:master Mar 27, 2022
@smdn
Copy link
Owner

smdn commented Mar 27, 2022

Released new version v1.0.3

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants