Fix #639: Disable pre-compilation for Go 1.16+ #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go compiler cache already mitigates the main benefit of the previous `go test -i` invocations. The previous replacement (running `go test`) makes goconvey slower and also breaks the UI :). At some point (I think) this should all be restructured so that we can pre-build all test binaries with a single `go test -c` invocation (so that we can take advantage of Go's internal compile scheduling). For now we'll just skip the pre-compilation step in order to un-break goconvey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go compiler cache already mitigates the main benefit of the
previous
go test -iinvocations. The previous replacement (runninggo test) makes goconvey slower and also breaks the UI :).At some point (I think) this should all be restructured so that we
can pre-build all test binaries with a single
go test -cinvocation (so that we can take advantage of Go's internal
compile scheduling). For now we'll just skip the pre-compilation
step in order to un-break goconvey.